New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace android.os.Looper by android.os.HandleThread to prevent blocking main thread #825

Open

JoBolNex wants to merge 1 commit into react-native-webrtc:master from JoBolNex:chore/fix-looper-loop-infinite

+17 −11

JoBolNex commented Jan 17, 2025 •

edited

Loading

This PR improves the handling of background threads for legacy phone state listening on Android versions below S (API 31). Key changes:

Replaced the manual Looper management with a dedicated HandlerThread
Added proper cleanup of the HandlerThread by implementing quitSafely() when stopping the listener
Moved HandlerThread to a class property to ensure proper lifecycle management and prevent potential memory leaks
Removed the blocking Looper.loop() call which could cause issues on the calling thread


          Replace android.os.Looper by android.os.HandleThread to prevent block…

457f2c4

…ing main thread

JoBolNex mentioned this pull request

VoiceConnectionServices not being invoked even when RNCallKeepModules are #824

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet